[转载]提交第一个patch,实质性贡献的第一步
(2010-09-10 09:09:27)
标签:
转载 |
分类: 开源专区 |
如今红旗2000有30多位工程师参与OOo社区的开发和对OOo版本的维护工作,其中有1人为OOo社区工程师委员会高层成员,3人为OOo社区开发项目的Lead,13人在OOo中担任开发者角色(被OOo确认的Developer role),主导或参与Open office.org10个有关项目的开发工作。OOo社区对他们在开发和维护工作中作出的贡献给予了高度评价。成修治和最初始的团队起了很大的作用
"2006年8月中旬,...开始摸索向OpenOffice.org社区提交由红旗2000的工程师修改的Bug的流程及方法。提交的第一个Bug是在演示文稿项目中,提交Bug时联系的第一个人是Graphics的Leader:KaiAhrens。由于当时的人力非常有限,公司在开源社区的知名度相对很小,所以,工作艰难地展开着,而开源技术部的工程师们细心、耐心、专心地工作着"--红旗2000开源历程之三
----- Original Message -----
From: "Kai Ahrens" <Kai.Ahrens@Sun.COM>
To: "blueeagle" <liutao@ch2000.com.cn>
Cc: "Thorsten Behrens" <Thorsten.Behrens@Sun.COM>
Sent: Friday, August 18, 2006 5:37 PM
Subject:Re: Fw: [Issue 68512] Direction of the text is wrong when
palying lantern slide
> blueeagle wrote:
>> Dear kai,
>>
>>
>>
>
> A patch is a file that contains the differences
between pairs of files,
> e.g. old file versus changed file, collected as
normal text output
> within the *.patch file.
>
> CVS is our internally used versioning system.
Some
> interesting pointers for beginners are here:
>
> http://www.gnomebangalore.org/?q=node/708
>
>> what is the CVS account and how to
get it?
>
> Working on our CVS tree directly (this is giving
you developer
> rights right now), doesn't seem to be a good idea,
obviously
> having no background of your work, so that the
only way
> to get your changes into the tree is to attach
your patch(es)
> to your issuezilla task and let them be reviewed
and committed
> by one of our experienced developers. Your role
might change
> in the future, but currently, I'm not willing to
grant
> you commit rights:
>
> This HowTo for creating a patch might help you to
create
> your own patch:
>
> http://cocoon.apache.org/2.1/howto/howto-patch.html
>
>> what is the CWS means?
>> what is the relationship between
CVS and CWS?
>
> A CWS is a so called Child Workspace, where
people
> can make their changes without the risk to break
the
> master tree. Actually, a CVS branch is created for
each
> workspace. The developer than works on this
branch
> only. After finishing his work completely, the
CWS
> is given to QA for testing the changes. After
the
> CWS has passed the QA, the changes within the
branch
> are joined into the master tree of the source
code.
>
> HTH
> Kai
“ oo.org的工作环境简介
oo.org所有的代码的编写都是先基于CWS(Child Workspace )上的,然后再移植到发布版的源码里的。在oo.org里CWS就是CVS的一个分支(branch),CVS为每个branch都创建了一个工作空间(Workspace),所有做与这个branch有关工作的开发者(developer)都在这个CWS里工作,所以当这个 branch 的工作未完成之前,所有改变产生的影响只出现在这个CWS里,和发布版的源码没有关系,只有当此 branch 的所有工作都完成了,之后再把代码提交给相关的QA 去测试,如果通过测试了,这样,这个 branch 的所有改变的代码才会移植到发布版的源码中去.
所有在CWS上工作的人都应该是developer 角色,并拥有可以提交代码的 CVS accout ,然后用这个CVS accout登入后,通过CVS工具直接往相应的CWS提交代码( commit code ) .所有的有关CWS的操作都必须基于拥有可以提交代码的 CVS accout的基础上的。
每个issue都应该隶属于某一个CWS。当一个issue被解决,更改的代码应该上传到这个CWS.
下面介绍怎样进入到oo.org的工作环境中..."
当时写的比较稚嫩,但进步还是迅速的,方法也是有效的,大家都热火朝天,现在我再招的人,看不到了那个热情。
http://graphics.openoffice.org/issues/show_bug.cgi?id=68512
是一个关于幻灯片放映的bug,
I have found a bug in SDrawing(presentation) (OO2.0.3).The bug can be described as follows : 1. build a new presentation 2. Input some words 3. change the style of these words to contour. 4. change the text direction from top to buttom.(or click the "text direction from top to buttom."button) 5. click the slide show button. You will find the direction of the text is wrong .
10月13日第一次提交patch
------- 附加注释人: liutao 2006/10/13 01:28:49 +0000 -------
Created an attachment (id=39708) the update patch of this bug 看看这个patch:
diff -uNr cppcanvas.new/source/mtfrenderer/textaction.cxx cppcanvas/source/mtfrenderer/textaction.cxx
--- cppcanvas.new/source/mtfrenderer/textaction.cxx2006-10-13 08:52:46.000000000 +0800
+++ cppcanvas/source/mtfrenderer/textaction.cxx2006-10-13 08:52:10.000000000 +0800
@@ -2140,6 +2140,8 @@
rStartPoint.Y() + aBaselineOffset.Height() ) ) );
const ::Size aReliefOffset( rVDev.LogicToPixel( rReliefOffset ) );
const ::Size aShadowOffset( rVDev.LogicToPixel( rShadowOffset ) );
+OutDevState rStateCopy=rState;
+rStateCopy.fontRotation = 0.0;
if( rState.isTextOutlineModeSet )
{
@@ -2155,7 +2157,7 @@
pDXArray,
rVDev,
rCanvas,
-rState,
+rStateCopy,